[9.0][ADD] base_kanban_stage: Stage model and abstract logic by tedsalmon · Pull Request #679 · OCA/server-tools

tedsalmon · 2016-12-28T18:56:29Z

Add Kanban-compatible stage model base.kanban.stage
Add views, menu items, actions, and access controls needed to manage
base.kanban.stage records
Add abstract model base.kanban.abstract that other models can inherit from to
gain Kanban stage functionality
Add base Kanban view base_kanban_abstract_view_kanban, which can be
customized as needed for use with models that inherit from base.kanban.abstract
Add model base.kanban.abstract.tester, which is needed for
web.kanban.abstract unit tests

This is a repo change based upon the discussions in PR OCA/web#490 (comment)
cc @lasley @obulkin

lasley · 2016-12-28T19:16:01Z

@t3ddftw - we lost @obulkin attribution in this. Do the following to fix:

Squash Oleg's commits in the previous branch, force push
Add LasLabs/web as a remote to your server-tools clone named as laslabs-web
Change to this branch, git reset --hard OCA/9.0 (assuming the OCA remote is named OCA in your local), don't push
git remote update && git cherry-pick HASH_FROM_SQUASHED
Resolve conflicts if any, commit, don't push
git cherry-pick 7d2216804a8cd710eb13c0ce629f741f45c93b62
Resolve conflicts, commit, force push after verifying no disaster
Delete the laslabs-web remote
Delete the branch in LasLabs/web (use github interface so it's recoverable just in case)

tedsalmon · 2016-12-28T20:03:26Z

@lasley,

Done! :)

lasley

Thanks @t3ddftw - few comments, but otherwise was reviewed in the previous PR

lasley · 2016-12-28T21:13:13Z

+
+    @api.model
+    def _default_stage_id(self):
+        return


Add # pragma: no cover

lasley · 2016-12-28T21:13:31Z

+
+* Dave Lasley <dave@laslabs.com>
+* Oleg Bulkin <obulkin@laslabs.com>
+* Daniel Reis


@dreispt - what email did you want here?

You can use dreis.pt@hotmail.com

dreispt

Great module!
Design looks good.
On the implementation I added a few questions.

dreispt · 2017-01-01T14:47:29Z

+
+* Dave Lasley <dave@laslabs.com>
+* Oleg Bulkin <obulkin@laslabs.com>
+* Daniel Reis


You can use dreis.pt@hotmail.com

dreispt · 2017-01-01T14:48:37Z

+    'author': "LasLabs, Odoo Community Association (OCA)",
+    'category': 'base',
+    'depends': [
+        'web_kanban',


I would rather replace this with a dependency on base, since this module does not modify or extend the web_kanban features.

dreispt · 2017-01-01T15:01:21Z

+    '''Inherit from this class to add support for Kanban stages to your model.
+    All public properties are preceded with kanban_ in order to isolate from
+    child models, with the exception of stage_id, which is a required field in
+    the Kanban widget and must be defined as such.'''


PEP257 prescribes: For consistency, always use """triple double quotes"""

dreispt · 2017-01-01T15:22:12Z

+             ' stage and with the same priority',
+    )
+    kanban_priority = fields.Selection(
+        selection=[('0', 'Normal'), ('5', 'Medium'), ('10', 'High')],


Any particular reasoning behind this priority scale?
I'm curious why not sticking to the scales using by official modules: 0,1 or 0,1,2.

@obulkin - Could you please comment on this?

Thanks!

This is more of a question for @lasley. I just used the scale that he introduced in https://github.com/OCA/vertical-medical/pull/121/files#diff-a9f682d57f72b368fcf819ed09e1f3c1R27.

I just made that stuff up, go ahead change it as @dreispt suggested

dreispt · 2017-01-01T15:24:50Z

+        default=lambda s: s._default_stage_id(),
+        domain=lambda s: [('res_model.model', '=', s._name)],
+    )
+    kanban_user_id = fields.Many2one(


Can we use user_id directly? AFAIK it is the field name expected for the responsible person (in places like the mail module logic).

dreispt · 2017-01-01T15:41:30Z

+    def _read_group_stage_ids(
+        self, domain=None, read_group_order=None, access_rights_uid=None
+    ):
+        stage_model = self.env['base.kanban.stage'].sudo(access_rights_uid)


If access_rights_uid is an optional argument, we should only use sudo if it is provided.

lasley · 2017-01-03T19:33:40Z

+
+    <record id="my_model_view_kanban" model="ir.ui.view">
+        <field name="name">My Model - Kanban View</field>
+        <field name="model">my.model</field>


Add name="mode">primary< & a note indicating that this must be set in order for the proper inheritance. Per the docs:

mode
inheritance mode, see Inheritance. If inherit_id is unset the mode can only be primary. If inherit_id is set, extension by default but can be explicitly set to primary

oca-clabot · 2017-01-03T21:25:31Z

Hey @tedsalmon, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@tedsalmon (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

lasley · 2017-01-03T21:27:03Z

@tedsalmon used to be @t3ddftw and is covered under the @LasLabs CLA. Can someone update please and thanks?

tedsalmon · 2017-01-03T21:51:35Z

@dreispt,

Updates made as requested :).

Failing build is not caused by any changes in this PR, FWIW.

Thanks!

* Add Kanban-compatible stage model web.kanban.stage * Add views, menu items, actions, and access controls needed to manage web.kanban.stage records * Add abstract model web.kanban.abstract that other models can inherit from to gain Kanban stage functionality * Add base Kanban view web_kanban_abstract_view_kanban, which can be customized as needed for use with models that inherit from web.kanban.abstract * Add model web.kanban.abstract.tester, which is needed for web.kanban.abstract unit tests

* Add Kanban-compatible stage model base.kanban.stage * Add views, menu items, actions, and access controls needed to manage base.kanban.stage records * Add abstract model base.kanban.abstract that other models can inherit from to gain Kanban stage functionality * Add base Kanban view base_kanban_abstract_view_kanban, which can be customized as needed for use with models that inherit from base.kanban.abstract * Add model base.kanban.abstract.tester, which is needed for base.kanban.abstract unit tests

* Add pragma no cover to `None` return in method

* Centralize default_stage_id and return empty RecordSet of type `base_kanban_stage`

* Update depends to `base` * Update priority selections to match Odoo guidelines * Update comment block to triple double quotes * Update `kanban_user_id` to `user_id` in code and view * Update README to incorporate use of mode in example view

lasley · 2017-01-03T21:54:57Z

Failing build is not caused by any changes in this PR, FWIW.

Rebased onto OCA/9.0

dreispt · 2017-01-06T14:54:02Z

Failing testes seem unrelated (😢 )
Merging!

Syncing from upstream OCA/server-tools (8.0)

tedsalmon force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from 7816cdf to 7d22168 Compare December 28, 2016 18:58

lasley mentioned this pull request Dec 28, 2016

[ADD][9.0] web_kanban_stage: Stage model and abstract logic OCA/web#490

Closed

lasley added the needs review label Dec 28, 2016

lasley changed the title ~~[ADD] base_kanban_stage: Stage model and abstract logic~~ [9.0][ADD] base_kanban_stage: Stage model and abstract logic Dec 28, 2016

lasley added this to the 9.0 milestone Dec 28, 2016

tedsalmon force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from 7d22168 to 540a97a Compare December 28, 2016 20:01

lasley approved these changes Dec 28, 2016

View reviewed changes

tedsalmon force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from e0ba631 to db936d8 Compare December 28, 2016 23:52

moylop260 approved these changes Dec 29, 2016

View reviewed changes

tedsalmon force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from f4d841f to cd0fb9b Compare December 29, 2016 23:30

lasley mentioned this pull request Dec 30, 2016

[10.0][MIG] base_kanban_stage #681

Merged

dreispt reviewed Jan 1, 2017

View reviewed changes

lasley reviewed Jan 3, 2017

View reviewed changes

tedsalmon force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from 8b27e7e to 693c1d4 Compare January 3, 2017 21:36

obulkin and others added 5 commits January 3, 2017 13:54

[FIX] base_kanban_stage: Add pragma no cover

f9d5960

* Add pragma no cover to `None` return in method

[IMP] base_kanban_stage: Centralize default stage ID

432708a

* Centralize default_stage_id and return empty RecordSet of type `base_kanban_stage`

IMP] base_kanban_stage: Updates per PR

6f3c0c0

* Update depends to `base` * Update priority selections to match Odoo guidelines * Update comment block to triple double quotes * Update `kanban_user_id` to `user_id` in code and view * Update README to incorporate use of mode in example view

lasley force-pushed the feature/9.0/LABS-134-create-medical_base_stage-object branch from 693c1d4 to 6f3c0c0 Compare January 3, 2017 21:54

dreispt approved these changes Jan 6, 2017

View reviewed changes

dreispt merged commit ac2e392 into OCA:9.0 Jan 6, 2017

tedsalmon deleted the feature/9.0/LABS-134-create-medical_base_stage-object branch January 6, 2017 19:01

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#679 from OCA/8.0

bbf0994

Syncing from upstream OCA/server-tools (8.0)

Uh oh!

Uh oh!

Conversation

tedsalmon commented Dec 28, 2016

Uh oh!

lasley commented Dec 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tedsalmon commented Dec 28, 2016

Uh oh!

lasley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dreispt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oca-clabot commented Jan 3, 2017

Uh oh!

lasley commented Jan 3, 2017

Uh oh!

tedsalmon commented Jan 3, 2017

Uh oh!

lasley commented Jan 3, 2017

Uh oh!

dreispt commented Jan 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lasley commented Dec 28, 2016 •

edited

Loading